Bugfix/certificate cleanup #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, only if a matching certificate is not found Signed-off-by: AssemblyJohn <[email protected]>
… for a private key Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
4 tasks
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/certificate_cleanup
branch
from
f5cedb5 to
1cf19dc
Compare
hikinggrass
requested changes
Apr 23, 2024
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/certificate_cleanup
branch
from
9696e66 to
d611622
Compare
|
Nits fixed. |
hikinggrass
approved these changes
Apr 23, 2024
hikinggrass
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes a bug in the certificate cleanup that was not keeping certificate keys when cleaning up. Now the keys are also kept.
Issue ticket number and link
Libocpp pull: EVerest/libocpp#583
Checklist before requesting a review