Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/75 deprecate openssl 1 #76

Merged
merged 5 commits into from
May 27, 2024
Merged

Conversation

AssemblyJohn
Copy link
Collaborator

@AssemblyJohn AssemblyJohn commented May 23, 2024

Describe your changes

Removed code calls to Openssl 1.1. Updated CMAKE to have a minimum version of OpenSSL 3.

Closes: #75 #38

Issue ticket number and link

#75
#38

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@AssemblyJohn AssemblyJohn linked an issue May 23, 2024 that may be closed by this pull request
This was referenced May 24, 2024
Copy link
Contributor

@Pietfried Pietfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README.md, which says this lib requires Openssl 1.1

Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Copy link
Collaborator Author

Updated, all entries mentioning OpenSSL.

@AssemblyJohn AssemblyJohn requested a review from Pietfried May 24, 2024 08:06
@barsnick
Copy link

Nice, good for consistency and code clean-up.

I'd like to see some of the (global) Dockerfiles and build instructions updated. I failed to find libssl3, even as PPA, for Debian 11 and Ubuntu 20.

@AssemblyJohn
Copy link
Collaborator Author

Nice, good for consistency and code clean-up.

I'd like to see some of the (global) Dockerfiles and build instructions updated. I failed to find libssl3, even as PPA, for Debian 11 and Ubuntu 20.

For Ubuntu 20 the only option is manual install (from sources). Will have to see for Debian.

@barsnick
Copy link

barsnick commented May 24, 2024

There are still some references to detection of OpenSSL v3, more code which can be reduced:

$ git -C ../libevse-security/ grep -Pnw USING_OPENSSL_3 origin/bugfix/75-deprecate-openssl-1
origin/bugfix/75-deprecate-openssl-1:lib/evse_security/crypto/openssl/openssl_tpm.cpp:8:#define USING_OPENSSL_3 (OPENSSL_VERSION_NUMBER >= 0x30000000L)
origin/bugfix/75-deprecate-openssl-1:lib/evse_security/crypto/openssl/openssl_tpm.cpp:10:#if USING_OPENSSL_3 && defined(USING_TPM2)
origin/bugfix/75-deprecate-openssl-1:tests/tests.cpp:20:#define USING_OPENSSL_3 (OPENSSL_VERSION_NUMBER >= 0x30000000L)
origin/bugfix/75-deprecate-openssl-1:tests/tests.cpp:22:#if USING_OPENSSL_3
origin/bugfix/75-deprecate-openssl-1:tests/tests.cpp:52:#endif // USING_OPENSSL_3
origin/bugfix/75-deprecate-openssl-1:tests/tests.cpp:72:#if USING_OPENSSL_3
origin/bugfix/75-deprecate-openssl-1:tests/tests.cpp:125:#endif // USING_OPENSSL_3

@AssemblyJohn AssemblyJohn requested a review from james-ctc May 24, 2024 11:25
@AssemblyJohn
Copy link
Collaborator Author

Extra dependencies removed.

@AssemblyJohn AssemblyJohn force-pushed the bugfix/75-deprecate-openssl-1 branch 2 times, most recently from 956e325 to 5e4b728 Compare May 24, 2024 12:02
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn AssemblyJohn force-pushed the bugfix/75-deprecate-openssl-1 branch from 937f4fa to 11fbf64 Compare May 27, 2024 11:04
@AssemblyJohn AssemblyJohn merged commit 8777cc2 into main May 27, 2024
4 checks passed
@AssemblyJohn AssemblyJohn deleted the bugfix/75-deprecate-openssl-1 branch May 27, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not build with OpenSSL 1.x
3 participants