-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/75 deprecate openssl 1 #76
Conversation
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the README.md, which says this lib requires Openssl 1.1
Signed-off-by: AssemblyJohn <[email protected]>
Updated, all entries mentioning OpenSSL. |
Nice, good for consistency and code clean-up. I'd like to see some of the (global) Dockerfiles and build instructions updated. I failed to find libssl3, even as PPA, for Debian 11 and Ubuntu 20. |
For Ubuntu 20 the only option is manual install (from sources). Will have to see for Debian. |
There are still some references to detection of OpenSSL v3, more code which can be reduced:
|
Extra dependencies removed. |
956e325
to
5e4b728
Compare
…ed test Signed-off-by: AssemblyJohn <[email protected]>
5e4b728
to
c5f049c
Compare
Signed-off-by: AssemblyJohn <[email protected]>
937f4fa
to
11fbf64
Compare
Describe your changes
Removed code calls to Openssl 1.1. Updated CMAKE to have a minimum version of OpenSSL 3.
Closes: #75 #38
Issue ticket number and link
#75
#38
Checklist before requesting a review