Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/custom openssl provider #86

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Conversation

AssemblyJohn
Copy link
Collaborator

@AssemblyJohn AssemblyJohn commented Jul 25, 2024

Describe your changes

In this PR there is offered the possibility to use a custom OpenSSL cryptography provider, along with the possibility to set up the desired operations for it. For example the provider can be used only to handle a certain subset of operations. The README has been updated to reflect the new changes.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Copy link
Collaborator

@james-ctc james-ctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good update to allow other provider names to be used.
Some minor updates suggested.

@AssemblyJohn AssemblyJohn force-pushed the feature/custom_openssl_provider branch 2 times, most recently from 3aab632 to 087fd22 Compare July 25, 2024 12:06
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn AssemblyJohn force-pushed the feature/custom_openssl_provider branch from 087fd22 to ed0f765 Compare July 25, 2024 12:09
@AssemblyJohn
Copy link
Collaborator Author

All comments have been handled, please re-review.

@AssemblyJohn AssemblyJohn requested a review from james-ctc July 25, 2024 12:09
Copy link
Collaborator

@james-ctc james-ctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

CMakeLists.txt Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should bump the project version at the top of this file to 0.8 (and release it after merge)

Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn AssemblyJohn merged commit 7624055 into main Jul 26, 2024
3 of 4 checks passed
@AssemblyJohn AssemblyJohn deleted the feature/custom_openssl_provider branch July 26, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants