Add coverage and use reusable workflow from everest-ci #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
…nd_test script Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
commented
Nov 11, 2024
| DESTINATION "${CMAKE_BINARY_DIR}/tests" | ||
| ) | ||
|
|
||
| install( | ||
| DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/configs" | ||
| file(COPY |
There was a problem hiding this comment.
Installing these files during configure makes the CI reusable workflow happy. Was there a reason why they were installed before? @james-ctc
There was a problem hiding this comment.
install was being used in other places so it was done to follow the same pattern.
Not a problem here, but in some tests there were issues that the file(COPY ...) doesn't appear to be part of the dependencies so when there is an update ninja/make doesn't copy the updates. It is possible that was the original reason for using install.
Elsewhere I have added specific targets where checking for updates is important.
moving away from using install is a very good improvement.
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review