Feature/pnc related #44
Conversation
- variant for `authorization_mode` in `AuthorizationReq` has been introduced - sdp packet buffer size has been increased to 4k, in order to be large enough to contain sample data from josev - crucial bug has been fixed in `ServiceDetail` serialization, where the `ParameterSet` has not been initialized/zero-initialized properly -- this will need some follow up discussion - some PnC related message and state handling has been added/refactored - minor refactorings on conversion functions Signed-off-by: aw <[email protected]>
- some comments have been added, which should be handled in near future Signed-off-by: aw <[email protected]>
Signed-off-by: aw <[email protected]>
| uint8_t buffer[2048]; | ||
| // FIXME (aw): what buffer size to allow here? Could also be made | ||
| // dynamic | ||
| uint8_t buffer[4096]; |
There was a problem hiding this comment.
Maybe we should start to use std::array instead of a c buffer.
I am fine with increasing the buffer size to 4096. I think that's more of an experience value. 4096 should be enough for now.
| @@ -17,6 +17,7 @@ namespace feedback { | |||
|
|
|||
| enum class Signal { | |||
| REQUIRE_AUTH_EIM, | |||
| REQUIRE_AUTH_PNC, | |||
There was a problem hiding this comment.
Here we should send also the contract cert chain from the AuthorizationReq message as well. But only once.
There was a problem hiding this comment.
This does not have to be part of this PR, but will be added when PnC is fully implemented.
| if (in.discharge_limits.has_value()) { | ||
| if (not in.discharge_limits) { | ||
| return; | ||
| } | ||
| auto& discharge_limits = in.discharge_limits.value(); |
There was a problem hiding this comment.
const auto instead of auto
| @@ -77,8 +88,7 @@ FsmSimpleState::HandleEventReturnType AuthorizationSetup::handle_event(Allocator | |||
| return sa.PASS_ON; | |||
| } | |||
|
|
|||
| // Todo(sl): PnC is currently not supported | |||
| ctx.feedback.signal(session::feedback::Signal::REQUIRE_AUTH_EIM); | |||
| ctx.feedback.signal(required_auth_signal(res)); | |||
There was a problem hiding this comment.
We should move this feedback.signal call to the authorization state. Only in the authorization state is it clear whether the car is requesting PnC or EIM.
Describe your changes
See commit messages
Issue ticket number and link
Checklist before requesting a review