Refactor interface & sdp server handling #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaLukas
commented
Nov 26, 2024
SebaLukas
commented
Nov 26, 2024
SebaLukas
commented
Nov 26, 2024
barsnick
requested changes
Dec 2, 2024
…pv6 interface will be selected. If no prober interface is provided, the tbd_controller throws an exception. The port from the sdp server is now reusable. The sdp socket binds now to the interface and joins multicast group Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
SebaLukas
force-pushed
the
refactor/check-interface-and-sdp-server
branch
from
df50777 to
882b571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added an interface check. If the interface is auto, the first found ipv6 interface will be selected. If no prober interface is provided, the tbd_controller throws an exception. The port from the sdp server is now reusable. The sdp socket binds now to the interface and joins multicast group
Issue ticket number and link
Checklist before requesting a review