Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logging backend to spdlog #23

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

Move logging backend to spdlog #23

wants to merge 47 commits into from

Conversation

hikinggrass
Copy link
Contributor

@hikinggrass hikinggrass commented Aug 15, 2024 •
edited
Loading

Replaces the currently used logging backend "Boost.Log" with "spdlog".
This is a drop-in replacement, especially currently used config files should work without any modification, however this does mean we still depend on "Boost.Log" for the parsing of the configuration files

@hikinggrass
WIP: use spdlog instead of Boost.Log
30dcacf 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Initialize line with 0
182d3eb 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Replace EVLOG_AND_THROW and EVTHROW macros with constrexpr functions
1dd6462 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Address some clang-tidy issues
bda0c19 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Add LogSource operator<< to control file name, line number and functi…
bd39374 
…on in the log

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Update example to showcase more features
362be38 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Fix gtest integration, add some first unit tests, fix coverage genera…
8365d5b 
…tion

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Change Filter in example logging.ini to show the %Process% contains s…
6bfd5ed 
…yntax

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Small log fix
6846122 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Fix is_level with and without %Process% contains
8bd88f8 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Implement a (hopefully) Boost.Log TextFile settings compatible rotati…
37e5b9c 
…ng file sink based on the rotating file sink example of spdlog

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Implement a simple Syslog sink
ee92a57 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Correctly limit maximum number of files in log rotation
2133f3c 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Respect file name and extension set in FileName when using default fo…
47aa3da 
…rmat string

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Convert EVEREST_INTERNAL_LOG_AND_THROW into constexpr template function
78ab778 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Throw EverestConfigError when no sinks are configured
5729b5d 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Add unit tests for Console and TextFile sinks
989eb46 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Set LOG_INSTALL to OFF in edm mode
c65ff9d 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Prefix coverage targets with PROJECT_NAME
db29554 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Add syslog smoketests
e221a54 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Add console defaults smoketest
a4d8c2c 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Add unit test for trace functionality
be05d33 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Generate code coverage and upload gcovr coverage report as artifact
4922edb 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
clang-format
5e1ddc3 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Only set cmake_policy CMP0167 (FindBoost handling) in cmake >= 3.30
c2bb124 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
install gcovr 6
e40185a 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Copy ctest-report and gcovr-coverage after install_and_test.sh for up…
4e876bb 
…loading as artifacts

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Attempt to fix path of gcovr output dir
7e12452 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
path fix
84ab5a7 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
revert last commit
68294cd 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
fix trap
213f21b 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Rewrite trap
0abde84 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
ls build
18280b8 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Fix gcovr-coverage path
8e6227d 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Fix usage of current_process_name
e390203 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Make ctors with one argument explicit
3d07bb9 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Fix get_process_name()
b4e088c 
/proc/PID/cmdline is NUL separated, treat it as such for parsing

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Add RotateOnOpen option to TextFile sink
0175b70 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Add test for a broken format string in TextFile FileName
cfba2e3 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass hikinggrass changed the title Feature/spdlog Move logging backend to spdlog Aug 19, 2024
@hikinggrass hikinggrass marked this pull request as ready for review August 20, 2024 08:48
@Pietfried Pietfried requested a review from andistorm August 20, 2024 08:51
SebaLukas
SebaLukas approved these changes Aug 20, 2024
View reviewed changes
Copy link

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my fedora 40 system without problems 👍

andistorm
andistorm reviewed Sep 2, 2024
View reviewed changes
.ci/build-kit/install_and_test.sh Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
andistorm and others added 7 commits September 2, 2024 15:43
@andistorm
Update CI
501a003 
* Add `build-kit-liblog`
* Use newer `build-kit-base`
* Split up scripts
* Refactor `build_and_test` workflow file

Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm
github.token -> secrets.GITHUB_TOKEN
6a15995 
Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm
Add trailing slash
ee04556 
Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm
Fix build dir path
7246769 
Signed-off-by: Andreas Heinrich <[email protected]>
@hikinggrass
Add missing newline
ffb6ef1 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Remove redundant enable_testing()
7e93da5 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Move coverage targt setup to tests subdir
eb62bb2 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass hikinggrass mentioned this pull request Sep 3, 2024
Closed
andistorm
andistorm approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐧

@hikinggrass
Add gcovr coverage xml target
608bb48 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebaLukas SebaLukas SebaLukas approved these changes

@andistorm andistorm andistorm approved these changes

Assignees

@andistorm andistorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hikinggrass @andistorm @SebaLukas