OCPP 1.6 Fix: add flag for pending firmware update #306
Conversation
Signed-off-by: Fabian Klemm <[email protected]>
| if (status == FirmwareStatusEnumType::SignatureVerified) { | ||
| this->firmware_update_is_pending = true; | ||
| } else if (status == FirmwareStatusEnumType::InstallationFailed || | ||
| status == FirmwareStatusEnumType::DownloadFailed || | ||
| status == FirmwareStatusEnumType::InstallVerificationFailed || | ||
| status == FirmwareStatusEnumType::InvalidSignature) { | ||
| this->firmware_update_is_pending = false; | ||
| } |
There was a problem hiding this comment.
Use switch with enums. With that the compiler gives warnings on missing unhandled values. Try to avoid using the default case as it deactivates this functionality with the usual -Wswitch (which is in -Wall, but not -Wswitch-enum, at least in gcc).
There was a problem hiding this comment.
Those two cases are not exhaustive (on purpose) though (so I would need a default case that just breaks to indeed avoid the warning). I added a comment in the code as explanation (of course, I could still also switch to a switch)
There was a problem hiding this comment.
Hmm, yeah, it may be inconvenient and look like boilerplate to write down all cases, but it helps for reviewing and maintenance. E.g. it seems at least the Installed case must also be handled here.
| EVLOG_debug << "Sending FirmwareUpdateStatusNotification with status" | ||
| << conversions::firmware_status_enum_type_to_string(status); |
There was a problem hiding this comment.
Isn't there a generic debug-log in this->send() already? 🤔
There was a problem hiding this comment.
Hmm which one do you mean? Could be that the websocket has some generic debug log. But for me the crucial aspect was that the logs actually reveal which (and in which order) firmware status updates (meaning the value) are sent and I don't think any existing log prints those (so I left this in case the firmware update make trouble again in the future)
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
* add flag for pending firmware update Signed-off-by: Fabian Klemm <[email protected]> * add comments Signed-off-by: Fabian Klemm <[email protected]> * fix comment grammar Signed-off-by: Fabian Klemm <[email protected]> * fix typo II Signed-off-by: Fabian Klemm <[email protected]> --------- Signed-off-by: Fabian Klemm <[email protected]>
In OCPP 1.6 , a flag that signals a pending firmware update is introduced. This fixes a bug in case the last received firmware status while a pending update is not "Downloaded" but something else (such as "Installing").