Security Log file option #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pp1.6 and ocpp2.0.1 Signed-off-by: pietfried <[email protected]>
Pietfried
force-pushed
the
feature/security-log-file
branch
from
4817df3 to
9a15914
Compare
hikinggrass
approved these changes
Jan 18, 2024
| @@ -69,6 +70,10 @@ MessageLogging::MessageLogging( | |||
| "</style>"; | |||
| this->html_log_file << "</head><body><table class=\"log\">\n"; | |||
| } | |||
| if (this->log_security) { | |||
| EVLOG_info << "Logging SecurityEvents to file"; | |||
| this->security_log_file.open(message_log_path + "/" + output_file_name + ".security.log"); | |||
There was a problem hiding this comment.
As far as I can see this overwrites the old already existing security log as it does not append?
There was a problem hiding this comment.
Or is the output_file_name different for each run?
There was a problem hiding this comment.
In 1.6 (and 2.0.1) the output_file_name is set to the current datetime:
So it's very likely different for each run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option for writing SecurityEvents to a security log file for ocpp1.6 and ocpp2.0.1.
This can be enabled by adding "security" to LogMessagesFormat configuration parameter.