Censor write only variables logging and added a new callback to sanitize any logging that would be passed to the existing message_callback #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcodenBesten
requested review from
Pietfried,
hikinggrass,
maaikez and
marcemmers
as code owners
|
The log line here: https://github.com/EVerest/libocpp/blob/main/lib/ocpp/common/websocket/websocket_libwebsockets.cpp#L996 can still leak secrets as it's not filtered. You could argue that it's debug so that's not needed, but better safe then sorry imo. Would love to here you're opinion on that. EDIT: as discussed during call today: remove it |
marcemmers
reviewed
Dec 12, 2024
WilcodenBesten
force-pushed
the
sensor-write-only-variables
branch
2 times, most recently
from
9f75036 to
bd8f5f4
Compare
…riable can be checked before the value change is logged. This prevents write-only varaiables to be logged Signed-off-by: Wilco den Besten <[email protected]>
…o the existing message_callback. Can be used to remove secrets from log lines Signed-off-by: Wilco den Besten <[email protected]>
Signed-off-by: Wilco den Besten <[email protected]>
Signed-off-by: Wilco den Besten <[email protected]>
Signed-off-by: Wilco den Besten <[email protected]>
WilcodenBesten
force-pushed
the
sensor-write-only-variables
branch
from
d031c56 to
983b199
Compare
hikinggrass
requested changes
Dec 20, 2024
| @@ -60,6 +60,7 @@ class MessageLogging { | |||
| std::filesystem::path security_log_file; | |||
| std::ofstream security_log_os; | |||
| std::mutex output_file_mutex; | |||
| std::function<std::string(const std::string& message)> sanitize_message_callback; | |||
There was a problem hiding this comment.
As discussed in the last WG meeting, lets drop this callback from this PR and just merge the write only variable logging changes. I'll follow up with a generic solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review