Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial scarthgap compatibility #30

Draft
wants to merge 3 commits into
base: kirkstone
Choose a base branch
from

Conversation

hikinggrass
Copy link
Contributor

Minimal changes to get scarthgap compatibility on the kirkstone branch. Since there are no major changes needed I just added this to the kirkstone branch to not have 2 almost identical branches that need to be kept up2date with each EVerest update

@Pietfried Pietfried requested a review from a-w50 June 4, 2024 08:37
@mhei
Copy link
Contributor

mhei commented Jun 17, 2024

Sorry, but personally I disaggree with the proposed approach. Even if there are no marjor changes now, I'd prefer to have the workflow established.

First, I would like to extend the README in this repo here to document, how the EVerest community supports different Yocto releases/branches. I can work on this but due to starting holidays, I cannot make any promises.

In addition to this organizational comment, some technical notes:

  • Some recipes (mostly the backported ones) are obsolete with scarthgap, since already included and even available in a newer version. This is why I'd recommend to drop them here.
  • This is why I also would prefer to have a dedicated branch for each (Yocto) upstream release.
  • I encountered build problems with the OCPP 2.0.1 module with the C++ compiler version in scarthgap but since I tried to build for our Tarragon platform and had to fiddle a little bit around to push it through, I'm not yet sure that I messed things up on my side. I'll investigate.

Disclaimer: personal opinion, not discussed/consolidated with with my employer team

@hikinggrass
Copy link
Contributor Author

Sorry, but personally I disaggree with the proposed approach. Even if there are no marjor changes now, I'd prefer to have the workflow established.

First, I would like to extend the README in this repo here to document, how the EVerest community supports different Yocto releases/branches. I can work on this but due to starting holidays, I cannot make any promises.

In addition to this organizational comment, some technical notes:

  • Some recipes (mostly the backported ones) are obsolete with scarthgap, since already included and even available in a newer version. This is why I'd recommend to drop them here.
  • This is why I also would prefer to have a dedicated branch for each (Yocto) upstream release.
  • I encountered build problems with the OCPP 2.0.1 module with the C++ compiler version in scarthgap but since I tried to build for our Tarragon platform and had to fiddle a little bit around to push it through, I'm not yet sure that I messed things up on my side. I'll investigate.

Disclaimer: personal opinion, not discussed/consolidated with with my employer team

I agree, let's have different branches for kirkstone and scarthgap, this was pretty much just a quick poc to see how much is needed to get this to work 😄

@hikinggrass hikinggrass marked this pull request as draft June 17, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants