Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/logging2 #9

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Feat/logging2 #9

merged 7 commits into from
Dec 8, 2023

Conversation

dorezyuk
Copy link
Contributor

@dorezyuk dorezyuk commented Dec 8, 2023

No description provided.

@dorezyuk dorezyuk requested a review from SirVer December 8, 2023 12:13
SirVer
SirVer reviewed Dec 8, 2023
View reviewed changes
zvt/src/logging.rs Outdated Show resolved Hide resolved
SirVer
SirVer approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@SirVer SirVer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, only naming remains. Everything else lgtm.

zvt/Cargo.toml Show resolved Hide resolved
zvt/src/lib.rs Outdated Show resolved Hide resolved
zvt/src/logging.rs Outdated Show resolved Hide resolved
@dorezyuk dorezyuk merged commit dd5c06d into main Dec 8, 2023
8 checks passed
@SirVer SirVer mentioned this pull request Dec 11, 2023
Closed
@dorezyuk dorezyuk deleted the feat/logging2 branch December 12, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirVer SirVer SirVer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorezyuk @SirVer