Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not passing real Respones Body File Paths to Frontend #96

Open
SoulKa opened this issue Oct 24, 2024 · 0 comments
Open

Not passing real Respones Body File Paths to Frontend #96

SoulKa opened this issue Oct 24, 2024 · 0 comments
Labels
backend Backend related task enhancement New feature or request

Comments

@SoulKa
Copy link
Collaborator

SoulKa commented Oct 24, 2024

We're currently keeping the absolute file system path to the response body file on the RufusResponse object. We're already using IDs for requests to prevent passing file paths to the frontend and should do the same for the response. This way, we're flexible about the handling of the response body storing logic and follow electrons recommendation on file paths in frontend.

Acceptance Criteria

  • The RufusResponse does not contain real filepaths
  • The response body loading/displaying still works
@SoulKa SoulKa added enhancement New feature or request backend Backend related task labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related task enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant