-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(108): Stream Request and Response Bodies #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason that we have not used main-event-service for the stream events? Do we need to have "lower level access" for performance or code readability reasons? Is the main-event-service abstraction unfit for this purpose?
The |
Changes
IpcPushStream
class in renderer, which receives stream data pushed to the renderer (a pull stream would be a stream that supportsread()
)ipcRenderer
methods in context bridgeEventEmitter
class in rendererTesting
Checklist