Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#179 - optimize pr template #180

Merged
merged 2 commits into from
Jan 23, 2025
Merged

#179 - optimize pr template #180

merged 2 commits into from
Jan 23, 2025

Conversation

giemic8
Copy link
Collaborator

@giemic8 giemic8 commented Jan 15, 2025 •
edited by SoulKa
Loading

Changes

Delete "Commit messages, branch names, code formatting adheres to our Contributing Guidelines" from pr template
close #179

Testing

If relevant, mention your manual testing here. If possible, include screenshots.

Checklist

  • Issue has been linked to this PR
  • Code has been reviewed by person creating the PR
  • Commit messages, branch names, code formatting adheres to our Contributing Guidelines
  • Automated tests have been written, if possible
  • Manual testing has been performed
  • Documentation has been updated, if necessary
  • Changes have been reviewed by second person

@giemic8 giemic8 enabled auto-merge (squash) January 15, 2025 20:08
kwerber
kwerber requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@kwerber kwerber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue description is missing an explanation as to why this entry will be removed

@giemic8 giemic8 closed this Jan 23, 2025
auto-merge was automatically disabled January 23, 2025 07:06

Pull request was closed

@giemic8 giemic8 reopened this Jan 23, 2025
@SoulKa SoulKa force-pushed the feature/179-optimize-pr-template branch from 15d39e3 to 0f3d96e Compare January 23, 2025 07:23
@SoulKa SoulKa merged commit ddff5bc into main Jan 23, 2025
2 checks passed
@SoulKa SoulKa deleted the feature/179-optimize-pr-template branch January 23, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwerber kwerber kwerber requested changes

@SoulKa SoulKa SoulKa approved these changes

Assignees

@giemic8 giemic8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change PR Template
3 participants
@giemic8 @SoulKa @kwerber