Add a test case for sub menu selected item #6592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JorickPepin. I'm closing this in favor of #6633, which adds a similar test and makes some code changes to fix the highlighting issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this adds a test covering the bug described in #6588.
I tried to do some digging but couldn't find a solution. Couldn't we use route names rather than URIs to determine matches by adding the name of the route to the
MenuItemDto$routeNameproperty, like it is done for$linkUrl?I made the test pass so as not to block the CI, but as described in the comment, the active tab in the test should be
Bills.