Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Move API key functions to API Key service #285

Merged
merged 1 commit into from
Sep 29, 2023
Merged

[chore] Move API key functions to API Key service #285

merged 1 commit into from
Sep 29, 2023

Conversation

nwithan8
Copy link
Member

Description

  • Move API key functions to API Key service
  • Deprecate existing API key function in User service

Testing

  • Move unit tests, cassettes as needed

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team September 28, 2023 20:54
@nwithan8 nwithan8 marked this pull request as draft September 28, 2023 21:13
@nwithan8
Copy link
Member Author

nwithan8 commented Sep 28, 2023 •
edited
Loading

Gotta love when the Maven plugin we use to check for vulnerable dependencies, is itself vulnerable. Standby for separate patch PR.

UPDATE: Awaiting a rebase once #286 is merged.

@nwithan8 nwithan8 marked this pull request as ready for review September 29, 2023 18:09
@nwithan8 nwithan8 merged commit ddc9882 into master Sep 29, 2023
16 checks passed
@nwithan8 nwithan8 deleted the api_keys branch September 29, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@dcaballeroc dcaballeroc dcaballeroc approved these changes

@jchen293 jchen293 Awaiting requested review from jchen293

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @dcaballeroc @Justintime50