Maniacs Feature - Add .relative & .centered support on PixelPanScreen #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great thanks for figuring out the algorithm |
fdelapena
approved these changes
Nov 23, 2024
When using .relative & .centered tags for PixelScrolling, do the following: - Get half the width/height of the screen - Move screen by ( h/v - screen_width/height ) divided by two. When compared to Maniacs Patch 240822, it works as expected. Tested using different resolutions, works like it should.
Ghabry
force-pushed
the
PixelScrolling
branch
from
1436b8c
to
011f533
Compare
|
Jenkins: Test this please Rebased the commit and deleted the merge commit. Looks good to me now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By Ghabry's request, here's the missing function .relative & .centered scrolling.
When using .relative & .centered tags for PixelScrolling, do the following:
Tested against Maniac Patch 240822, it works as expected.
Tested using different resolutions on Maniac and EasyRPG, works as expected.