-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all libs except ICU #60
Conversation
- Apply pkgconfig patch (upstream) to fix static linking - 3DS, Wii, Switch, Vita: Add climits include - Android: Disable mmap via HB_NO_MMAP
Have some quick'n'dirty scripts that build everything and then build the Player so I have a linking test. |
Okay everything compiled and is ready :) |
@@ -76,7 +76,7 @@ function build() { | |||
export PATH=$PLATFORM_PREFIX/bin:$PATH | |||
|
|||
export CFLAGS="-g0 -O2 $5" | |||
export CXXFLAGS=$CFLAGS | |||
export CXXFLAGS="$CFLAGS -DHB_NO_MMAP" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only add such flags for libraries needing them → harfbuzz, libopus SIMD (#61).
But this will complicate this PR, so ignoring for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is for harfbuzz only. I wanted to pass CXXFLAGS= as part of install lib argument but didn't work.
Rebuilding toolchains:
|
macOS and iOS failed to build because I forgot to git add the patch file. Sorry 🙄 Not at my dev PC, if somebody wants to open a PR: https://github.com/xiph/ogg/commit/c8fca6b4a02d695b1ceea39b330d4406001c03ed.patch |
Player build success status:
Library building only (because we have no up-to-date CMake invocation for this)