Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all libs except ICU #60

Merged
merged 4 commits into from
Apr 4, 2020
Merged

Update all libs except ICU #60

merged 4 commits into from
Apr 4, 2020

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Apr 2, 2020

Player build success status:

  • Linux (+Player UnitTest)
  • Android
  • JS
  • 3DS
  • Wii
  • Switch
  • Vita
  • macOS (+Player UnitTest)

Library building only (because we have no up-to-date CMake invocation for this)

  • iOS

Ghabry added 2 commits April 2, 2020 18:54
- Apply pkgconfig patch (upstream) to fix static linking
- 3DS, Wii, Switch, Vita: Add climits include
- Android: Disable mmap via HB_NO_MMAP
@Ghabry
Copy link
Member Author

Ghabry commented Apr 2, 2020

Have some quick'n'dirty scripts that build everything and then build the Player so I have a linking test.
Building worked everywhere except macos because I have a network error when downloading ICU -_-

@Ghabry
Copy link
Member Author

Ghabry commented Apr 2, 2020

Okay everything compiled and is ready :)

@Ghabry Ghabry changed the title [WIP] Update all libs except ICU Update all libs except ICU Apr 2, 2020
@@ -76,7 +76,7 @@ function build() {
export PATH=$PLATFORM_PREFIX/bin:$PATH

export CFLAGS="-g0 -O2 $5"
export CXXFLAGS=$CFLAGS
export CXXFLAGS="$CFLAGS -DHB_NO_MMAP"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only add such flags for libraries needing them → harfbuzz, libopus SIMD (#61).
But this will complicate this PR, so ignoring for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is for harfbuzz only. I wanted to pass CXXFLAGS= as part of install lib argument but didn't work.

@carstene1ns carstene1ns merged commit 21714a1 into EasyRPG:master Apr 4, 2020
@carstene1ns
Copy link
Member

carstene1ns commented Apr 4, 2020

Rebuilding toolchains:

  • Linux
  • Android
  • JS
  • 3DS
  • Wii
  • Switch
  • Vita
  • macOS FAILED
  • ios FAILED

@Ghabry
Copy link
Member Author

Ghabry commented Apr 4, 2020

macOS and iOS failed to build because I forgot to git add the patch file. Sorry 🙄

Not at my dev PC, if somebody wants to open a PR:
Put this file as "libogg-fix-typedefs.patch" in both macosx and ios folder:

https://github.com/xiph/ogg/commit/c8fca6b4a02d695b1ceea39b330d4406001c03ed.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants