EEH-2488 - Gotten rid of the controlled_vocabulary_schemas
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We decided to loose the constraint so that we wouldn't be required to update a never ending CV list, and also to work around elixir-europe/biovalidator#56
And got rid of the "controlled_vocabulary_schemas" of assayTypes and subtypes
…omolecule as an ontologyTerm property
This goes better with the ontologies' nomenclature and our experiment's schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket reference
EEH-2488
Overall changes
assayTypeinto anontologyTerm-propertycontrolled_vocabulary_schemasassayTypeassayedMoleculeTypeintoassayedBiologicalMacromoleculeas anontologyTerm-propertyarraySampleLabelsassayTypetoassayInstrumentAssayTypeand assayed moleculesFuture TO-DOs
async keyword in sync schemaelixir-europe/biovalidator#57), I am unable to check if the JSON documents are valid or not. Instead, once merged with main, I will check fetching them through BioV, works around this issue.