feat: add fallback to GITHUB_SHA #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienFromToulouse
force-pushed
the
feature/fallbackDefaultToSingleCommitSha
branch
16 times, most recently
from
c84dda5 to
3731af2
Compare
AdrienFromToulouse
added
echoes: other
AdrienFromToulouse
force-pushed
the
feature/fallbackDefaultToSingleCommitSha
branch
from
3731af2 to
44d7b54
Compare
AdrienFromToulouse
force-pushed
the
feature/fallbackDefaultToSingleCommitSha
branch
3 times, most recently
from
26d991b to
efcad93
Compare
AdrienFromToulouse
force-pushed
the
feature/fallbackDefaultToSingleCommitSha
branch
from
efcad93 to
54a93be
Compare
lucasdicioccio
previously approved these changes
Sep 14, 2023
icecrime
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More than only implementing the fallback to
$GITHUB_SHA, it also takes the chance to improve the README and error messages provided by the action itself.Additionally, it removes the unnecessary fallback for the
versionproperty since it is no required anymore by the Deployments API and ignores thenameproperty also soon not to be considered by Echoes.