Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for comma separated list of commits & deliverables #6

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

AdrienFromToulouse
Copy link
Contributor

@AdrienFromToulouse AdrienFromToulouse commented Oct 28, 2024

The main motivation behind this change is to simplify the way commits or deliverables are passed to the Action.
It was previously accepting only a new line separated list of values while now it would also support a comma separated list of values.

Important to notice that GITHUB_ENV or GITHUB_OUTPUT do not support multi line values making the previous design tedious to work with.

@AdrienFromToulouse AdrienFromToulouse added the echoes: maintenance Changes intended at preserving our ability to evolve the software safely and effectively label Oct 28, 2024
@AdrienFromToulouse AdrienFromToulouse force-pushed the fix/mapfile branch 2 times, most recently from a9c6d40 to 60f4aa5 Compare October 28, 2024 12:51
@AdrienFromToulouse AdrienFromToulouse changed the title fix: better handling of commits and deliverables inputs feat: support for comma separated list of commits & deliverables Oct 28, 2024
@AdrienFromToulouse AdrienFromToulouse force-pushed the fix/mapfile branch 6 times, most recently from ef6fe93 to 694ec58 Compare October 28, 2024 13:53
@AdrienFromToulouse AdrienFromToulouse marked this pull request as ready for review October 28, 2024 13:54
@AdrienFromToulouse AdrienFromToulouse merged commit ecc7203 into main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: maintenance Changes intended at preserving our ability to evolve the software safely and effectively
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants