This repository has been archived by the owner on May 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 166
Dev #275
Open
yarivkohn
wants to merge
25
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code would only store the most recent version of the scop data when calling applyTestScope. If you called the method twice then you lost the original scope. Parts of the EcomDev_PHPUnit code are using the registry to store information. Currently the test scope is only setup at the suite level but if tests in the suite expect a clean registry then there are problems. This change converts to using a stack to store the scope. Each time you call applyTestScope the current scope data is added to the stack. Each time you call discardTestScope the previous scope data is restored. If you call discardTestScope and there is no stored scope data, a RuntimeException is thrown.
Clear params on dispatch
…fixes Suggest a couple of typo fixes in README.md
Signed-off-by: Michael A. Smith <[email protected]>
Disable Events without Disabling Event Capture
Issue/178 fixture scope
Magento 1.9.1.0 and PHP 5.5.
Update travis environment and PHP versions
…hpunit version to major one
Passed content constraints were been ignored because of wrong type.
Fix constraint type for assertLayoutBlockRenderedContent[Not]()
…Unit_Model_Layout
Reset _beforeForwardInfo to make multiple forward assertions possible
Fix default value for 'attribute_set_id'.
Integrate PHP 7 compatibility patch from Inchoo_PHP7 into EcomDev_PHP…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.