Fix android build by migrating androidx modules #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EddyVerbruggen could you please take a look? I'm facing this problem when installing fingerprint-aio plugin, I think it does something androidx related and there is a compatibility issue, and I need both plugins. Thanks! |
|
I tested the pull request on Android 10 and can verify that it works as expected. |
|
Thanks guys! I'll do a major version bump, just to be on the safe side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issues attempting to use this plugin for a Ionic 5 capacitor project.
This seemed to be a common issue:
#155
#157
I looked into it a bit more and saw android.support libraries are now replaced with androidx by default for Ionic.
So I changed the imports and found I was able to build and use the CustomTabs android implementation of this plugin.
Here are the changes I made to get it to build and run.
This would appear to be a breaking change so I will leave with @EddyVerbruggen to decide on merging this change.