Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 11 package visibility #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ucsbricks
Copy link

Implemented fix discussed in #179. Tested and is working fine on my devices and emulators.

See https://developer.android.com/training/package-visibility for details.

@ldgfb
Copy link

ldgfb commented Aug 18, 2021

Thanks for sharing this fix. Would be great to get this merged; without it this plugin is broken on Android 11.

@slissner
Copy link

As November 2021 deadline is approaching, any possibility to get this merged soon? Thank you very much!

@SrPatinhas
Copy link

Is there any ETA to merge this PR and publish a new version? with the Android 12 coming out a 4th October, this will be a needed fix for any smartphone that uses Google Chrome as default browser.

@ucsbricks
Copy link
Author

@EddyVerbruggen could you please have a look on this PR and merge it? Thanks.

@alexneats
Copy link

Agreed. This fix is great because, it works! I would LOVE for v2.0.1 of this plugin to get pushed out soon too, please! (:

@slissner
Copy link

slissner commented Nov 15, 2021

I have merged this pull request into my forked repository: slissner#1

Herewith I can confirm that the changes have worked with a real Pixel 5 Android 12 device.

Update: tried with simulator Pixel 5 Android 11 (API v30) device: It did not work.

@slissner
Copy link

slissner commented Nov 16, 2021

For those who try to test this pull request in a android simulator device: Make sure you have at least one browser (e.g. chrome) installed on your virtual device that supports the custom tabs functionality.

Background:

As mentioned in my previous comment, the custom tabs did not work on my simulator device. The problem was that by default no browser at all was installed on that device. After installing chromium, it worked well.

Where is Custom Tabs available?

Custom Tabs is a feature supported by browsers on the Android platform. It was originally introduced by Chrome, on version 45. Currently, the protocol is supported by most Android

Source: https://developer.chrome.com/docs/android/custom-tabs/#where-is-custom-tabs-available

How to install chrome on for an android emulator:

@WuglyakBolgoink
Copy link

@slissner

Update: tried with simulator Pixel 5 Android 11 (API v30) device: It did not work.

but it open WebView Modal

image

@WuglyakBolgoink
Copy link

as a fallback fix you can use my plugin

https://github.com/WuglyakBolgoink/cordova-plugin-quick-fix-svc

simon-strudwick added a commit to Personal-Group/cordova-plugin-safariviewcontroller that referenced this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants