-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 11 package visibility #180
base: master
Are you sure you want to change the base?
Android 11 package visibility #180
Conversation
Thanks for sharing this fix. Would be great to get this merged; without it this plugin is broken on Android 11. |
As November 2021 deadline is approaching, any possibility to get this merged soon? Thank you very much! |
Is there any ETA to merge this PR and publish a new version? with the Android 12 coming out a 4th October, this will be a needed fix for any smartphone that uses Google Chrome as default browser. |
@EddyVerbruggen could you please have a look on this PR and merge it? Thanks. |
Agreed. This fix is great because, it works! I would LOVE for v2.0.1 of this plugin to get pushed out soon too, please! (: |
I have merged this pull request into my forked repository: slissner#1 Herewith I can confirm that the changes have worked with a real Pixel 5 Android 12 device. Update: tried with simulator Pixel 5 Android 11 (API v30) device: It did not work. |
For those who try to test this pull request in a android simulator device: Make sure you have at least one browser (e.g. chrome) installed on your virtual device that supports the custom tabs functionality. Background: As mentioned in my previous comment, the custom tabs did not work on my simulator device. The problem was that by default no browser at all was installed on that device. After installing chromium, it worked well.
Source: https://developer.chrome.com/docs/android/custom-tabs/#where-is-custom-tabs-available How to install chrome on for an android emulator: |
but it open WebView Modal |
as a fallback fix you can use my plugin https://github.com/WuglyakBolgoink/cordova-plugin-quick-fix-svc |
Implemented fix discussed in #179. Tested and is working fine on my devices and emulators.
See https://developer.android.com/training/package-visibility for details.