Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLOUDDEV-1134): fix add sg without port #178

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix(CLOUDDEV-1134): fix add sg without port #178

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0a3bafa
fix(CLOUDDEV-1134): fix add sg without port
Nov 2, 2024
51364c6
fix(CLOUDDEV-1134): changed resource sg port type from int to string
Nov 13, 2024
8de6b71
fix(CLOUDDEV-1134): changed resource sg port type from int to string
Nov 13, 2024
f4952ff
fix(CLOUDDEV-1134): changed resource sg port type from int to string
Nov 13, 2024
7f2b7d6
fix(CLOUDDEV-1134): changed resource sg port type from int to string
Nov 13, 2024
4827dd6
fix(CLOUDDEV-1134): changed resource sg port type from int to string
Nov 13, 2024
f6db4ab
fix(CLOUDDEV-1134): changed resource sg port type from int to string
Nov 13, 2024
d87db82
fix(CLOUDDEV-1134): changed resource sg port type from int to string
Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions edgecenter/resource_edgecenter_securitygroup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,13 @@ func resourceSecurityGroup() *schema.Resource {
"port_range_min": {
Type: schema.TypeInt,
Optional: true,
Default: 1,
Computed: true,
ValidateFunc: validation.IntBetween(1, 65535),
},
"port_range_max": {
Type: schema.TypeInt,
Optional: true,
Default: 65535,
Computed: true,
ValidateFunc: validation.IntBetween(1, 65535),
},
"description": {
Expand Down Expand Up @@ -250,8 +250,13 @@ func resourceSecurityGroupCreate(ctx context.Context, d *schema.ResourceData, m
return diag.FromErr(fmt.Errorf("value of the port_range_min cannot be greater than port_range_max"))
}

sgrOpts.PortRangeMax = &portRangeMax
sgrOpts.PortRangeMin = &portRangeMin
if portRangeMax != 0 {
sgrOpts.PortRangeMax = &portRangeMax
}

if portRangeMin != 0 {
sgrOpts.PortRangeMin = &portRangeMin
}

rules[i] = sgrOpts
}
Expand Down
Loading