chore(CLOUDDEV-1074): Remove and fix examples #180
Merged
+60
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
А это что за пример? Просто сам добавил недостающий ресурс? Желательно согласоваться с командой CDN
There was a problem hiding this comment.
Там был пример и в нём была ошибка, линтер подсвечивал красным. Я подправил. То что добавлял, взял из другого примера про edgecenter_cdn_origingroup. Давай, конечно, согласую
There was a problem hiding this comment.
Да, все ок. Если в resource указать origin_group, то часть манифеста с origin_group обязательно должна быть описана. Иначе apply для такого манифеста не пройдет.
DamirZinatullin
approved these changes
Dec 10, 2024
Leonid-St
approved these changes
Dec 10, 2024
DamirZinatullin
approved these changes
Dec 10, 2024
dodgyturtle
deleted the
refactor/CLOUDDEV-1074-remove-unused-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.