Convert from pcre1 to pcre2 #316
Open
+142
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge os master
* Convert from pcre1 to pcre2 * comments * README
dev0z
reviewed
Jan 12, 2024
| @@ -62,6 +62,6 @@ TEST_CASE( "pcre obj test", "[regex]" ) { | |||
| } | |||
| uint64_t l_dt_s; | |||
| l_dt_s = ns_waflz::get_delta_time_ms(l_t_s); | |||
| REQUIRE(l_dt_s < 200); | |||
There was a problem hiding this comment.
I wrote a benchmark where I use the regexes from the OWASP rules and and it is 2-3x times faster than pcre1 but for this test it is slower
There was a problem hiding this comment.
do you have the benchmark tests handy? That sounds promising.
There was a problem hiding this comment.
I added a repo here: https://github.com/atn1990/compare-regex
There was a problem hiding this comment.
@atn1990 @MichaelClayMoore and I are working on this. We'll update you soon
|
Can anyone help debug the failing test on MacOS? It says there are symbols not found in the std namespace so I don't see how that is caused by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the library to use pcre2 from pcre1 using various sources on the internet and the official documentation