Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FKED-89: Add support for deleting scenes from open experience 🖼💥 #36

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

techninja
Copy link
Member

FKED-89: As a user I'd like to delete scenes

Based on #35, so merge that first.

This PR does the following:

  • Adds a new button for the scene card component (plus associated api, action, and reducer methods), allowing for complete deletion of scenes via the API and in the UI

To Review:

  • Checkout this branch, run yarn start, and login with your credentials.
  • Create a test experience, and at least 3 test scenes.
  • See that delete buttons (with 🗑 icons) appear on the scene cards
  • Click the "Delete" button on a scene that is not being edited
  • See that you're presented with a modal confirmation dialog
  • Click "Cancel" and verify that nothing happens
  • Click the delete again, and the click confirm
  • See that the scene card disappears, and on page refresh the scene is gone.
  • Click to edit a scene (if one isn't open).
  • Click the delete button on that scene (the card should have a green outline)
  • See that the scene edit unloads after deletion and you can continue editing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant