New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audio slider implementation (work on chromium ) issue 173 #178

Open

tosirap wants to merge 1 commit into EdwardDunn:master from tosirap:master

tosirap commented Apr 28, 2018

Nice project


          audio slider implementation

c2c6799

Owner

EdwardDunn commented May 4, 2018

@tosirap Thanks for your contribution!

The slider looks cool. There is a couple issues I noticed in testing though;

Music no longer mutes when settings modal opens
Slider not working in Firefox (I know your issue says its for Chromium but we would need it to go work in at least Firefox too)
The mute audio button is crossed out on page load (audio off when its on)

Hope this helps!

If you need any help just leave a comment.

EdwardDunn added the awaiting-update label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-update