Relax Trie variance

[KhraksMamtsov]

Type

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

Related

• Related Issue #
• Closes #

[changeset-bot]

🦋 Changeset detected

Latest commit: a0ca56c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
effect	Patch
@effect/cli	Patch
@effect/cluster-browser	Patch
@effect/cluster-node	Patch
@effect/cluster-workflow	Patch
@effect/cluster	Patch
@effect/experimental	Patch
@effect/opentelemetry	Patch
@effect/platform-browser	Patch
@effect/platform-bun	Patch
@effect/platform-node-shared	Patch
@effect/platform-node	Patch
@effect/platform	Patch
@effect/printer-ansi	Patch
@effect/printer	Patch
@effect/rpc-http	Patch
@effect/rpc	Patch
@effect/sql-clickhouse	Patch
@effect/sql-d1	Patch
@effect/sql-drizzle	Patch
@effect/sql-kysely	Patch
@effect/sql-libsql	Patch
@effect/sql-mssql	Patch
@effect/sql-mysql2	Patch
@effect/sql-pg	Patch
@effect/sql-sqlite-bun	Patch
@effect/sql-sqlite-do	Patch
@effect/sql-sqlite-node	Patch
@effect/sql-sqlite-react-native	Patch
@effect/sql-sqlite-wasm	Patch
@effect/sql	Patch
@effect/typeclass	Patch
@effect/vitest	Patch
@effect/ai	Patch
@effect/ai-openai	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[tim-smart]

A Trie has setter APIs so you can't relax the variance.

If there was a ReadonlyTrie that could be covariant.

[KhraksMamtsov]

But this is the case with HashSet and HashMap and List, and soundness is ensured by immutability as far as I understand. Trie setters are also immutable.

[mikearnaldi]

A Trie has setter APIs so you can't relax the variance.

If there was a ReadonlyTrie that could be covariant.

I think as long as it is immutable it should work