Add Effect.whenLogLevel
#4342
Open
Add Effect.whenLogLevel
#4342
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cc68a42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tim-smart
requested changes
Jan 30, 2025
| <A, E, R>(effect: Effect.Effect<A, E, R>, level: LogLevel.LogLevel) => Effect.Effect<Option.Option<A>, E, R> | ||
| >(2, (effect, level) => { | ||
| return core.withFiberRuntime((fiberState) => { | ||
| const currentLogLevel = FiberRef.currentMinimumLogLevel.pipe(fiberState.getFiberRef) |
There was a problem hiding this comment.
No need for the .pipe here
| @@ -948,6 +948,20 @@ export const logAnnotations: Effect.Effect<HashMap.HashMap<string, unknown>> = c | |||
| core.currentLogAnnotations | |||
| ) | |||
|
|
|||
| /** @internal */ | |||
| export const whenLogLevel = dual< | |||
| (level: LogLevel.LogLevel) => <A, E, R>(effect: Effect.Effect<A, E, R>) => Effect.Effect<Option.Option<A>, E, R>, | |||
There was a problem hiding this comment.
I think we should support passing a string literal too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
This is the result from the following Discord discussion: https://discord.com/channels/795981131316985866/1332442902629978132, it implements a new function
Effect.whenLogLevel, for which the specified effect is only executed whenever the log level is enabled.I am unsure if the return type here is okay, currently it permits the effect to return a value, and wrap the return value in
Option.Option. The other possibility would be to simply say the return must be (like forEffect.tap) to bevoid. I could imagine scenarios in which it could be helpful to get the return value, but also feel like that it could be abused in a sense, 95% of usecases would likely justyield*without considering the return value (but one could for example use the return value to determine if other diagnostics should be generated, etc.)Related