Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoggerProvider support to @effect/opentelemetry #4371

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

jpowersdev
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Add LoggerProvider and LogRecordProcessor support to @effect/opentelemetry, as well as a logger layer (using Logger.addEffect to run alongside existing loggers) that will emit logs using the registered LogRecordProcessor.

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: b710d35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/opentelemetry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpowersdev
Copy link
Contributor Author

Working on tests and docs before removing draft status

@jpowersdev jpowersdev changed the title Add otel logger provider support Add LoggerProvider support to @effect/opentelemetry Jan 31, 2025
@jpowersdev
Copy link
Contributor Author

I tried to follow the existing structure as best I could, but please let me know if anything needs to be modified.

@jpowersdev jpowersdev marked this pull request as ready for review January 31, 2025 03:13
@jpowersdev jpowersdev requested a review from tim-smart as a code owner January 31, 2025 03:13
packages/opentelemetry/src/internal/logger.ts Outdated Show resolved Hide resolved
packages/opentelemetry/src/internal/logger.ts Outdated Show resolved Hide resolved
packages/opentelemetry/src/Logger.ts Show resolved Hide resolved
@tim-smart tim-smart merged commit 57d1623 into Effect-TS:main Feb 5, 2025
12 checks passed
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants