Arbitrary: remove NaN while generating numeric template literals (#500)

Effect-TS · Oct 19, 2023 · e9ff876 · e9ff876
1 parent 77b827e
commit e9ff876
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/red-flies-push.md b/.changeset/red-flies-push.md
@@ -0,0 +1,5 @@
+---
+"@effect/schema": patch
+---
+
+Arbitrary: remove NaN while generating numeric template literals
diff --git a/src/Arbitrary.ts b/src/Arbitrary.ts
@@ -118,12 +118,14 @@ export const go = (ast: AST.AST, constraints?: Constraints): Arbitrary<any> => {
       return (fc) => fc.oneof(fc.object(), fc.array(fc.anything()))
     case "TemplateLiteral": {
       return (fc) => {
+        const string = fc.string({ maxLength: 5 })
+        const number = fc.float({ noDefaultInfinity: true }).filter((n) => !Number.isNaN(n))
         const components: Array<FastCheck.Arbitrary<string | number>> = [fc.constant(ast.head)]
         for (const span of ast.spans) {
           if (AST.isStringKeyword(span.type)) {
-            components.push(fc.string({ maxLength: 5 }))
+            components.push(string)
           } else {
-            components.push(fc.float({ noDefaultInfinity: true }))
+            components.push(number)
           }
           components.push(fc.constant(span.literal))
         }