fix: speed up container creation by removing chown -R, and incrementa…

…l build by switching to gmake
EffectiveRange · Dec 7, 2024 · 806a2d1 · 806a2d1
1 parent c7f9cd6
commit 806a2d1
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 9 deletions.
diff --git a/amd64-container/Dockerfile b/amd64-container/Dockerfile
@@ -11,8 +11,9 @@ ARG USER_GID=$USER_UID
 RUN groupadd --gid $USER_GID $USERNAME \
     && useradd -s /bin/bash --uid $USER_UID --gid $USER_GID -m $USERNAME \
     && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
-    && chmod 0440 /etc/sudoers.d/$USERNAME && chown -R $USERNAME:$USERNAME /opt/debs \
-    && [ -f  /etc/schroot/chroot.d/buildroot ] && chown -R $USERNAME:$USERNAME /var/chroot/buildroot  && sed -ri "s/(users=.*)/\1,$USERNAME/g" /etc/schroot/chroot.d/buildroot || true
+    && chmod 0440 /etc/sudoers.d/$USERNAME
+RUN chown -R $USERNAME:$USERNAME /opt/debs
+RUN [ -f  /etc/schroot/chroot.d/buildroot ] && sed -ri "s/(users=.*)/\1,$USERNAME/g" /etc/schroot/chroot.d/buildroot || true
 
 # ********************************************************
 # * Anything else you want to do like clean up goes here *

diff --git a/amd64-container/devcontainer.json b/amd64-container/devcontainer.json
@@ -29,7 +29,7 @@
 	// Configure tool-specific properties.
 	,
 	"containerEnv": {
-		"CMAKE_GENERATOR": "Ninja"
+		"CMAKE_GENERATOR": "Unix Makefiles"
 	},
 	"customizations": {
 		"vscode": {

diff --git a/arm64-container/Dockerfile b/arm64-container/Dockerfile
@@ -11,8 +11,9 @@ ARG USER_GID=$USER_UID
 RUN groupadd --gid $USER_GID $USERNAME \
     && useradd -s /bin/bash --uid $USER_UID --gid $USER_GID -m $USERNAME \
     && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
-    && chmod 0440 /etc/sudoers.d/$USERNAME && chown -R $USERNAME:$USERNAME /opt/debs \
-    && [ -f  /etc/schroot/chroot.d/buildroot ] && chown -R $USERNAME:$USERNAME /var/chroot/buildroot  && sed -ri "s/(users=.*)/\1,$USERNAME/g" /etc/schroot/chroot.d/buildroot || true
+    && chmod 0440 /etc/sudoers.d/$USERNAME
+RUN chown -R $USERNAME:$USERNAME /opt/debs
+RUN [ -f  /etc/schroot/chroot.d/buildroot ] && sed -ri "s/(users=.*)/\1,$USERNAME/g" /etc/schroot/chroot.d/buildroot || true
 
 # ********************************************************
 # * Anything else you want to do like clean up goes here *

diff --git a/arm64-container/devcontainer.json b/arm64-container/devcontainer.json
@@ -30,7 +30,7 @@
 	,
 	"containerEnv": {
 		"CMAKE_TOOLCHAIN_FILE": "/usr/share/cmake/toolchain.cmake",
-		"CMAKE_GENERATOR": "Ninja"
+		"CMAKE_GENERATOR": "Unix Makefiles"
 	},
 	"customizations": {
 		"vscode": {

diff --git a/armhf-container/Dockerfile b/armhf-container/Dockerfile
@@ -11,8 +11,9 @@ ARG USER_GID=$USER_UID
 RUN groupadd --gid $USER_GID $USERNAME \
     && useradd -s /bin/bash --uid $USER_UID --gid $USER_GID -m $USERNAME \
     && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
-    && chmod 0440 /etc/sudoers.d/$USERNAME && chown -R $USERNAME:$USERNAME /opt/debs \
-    && [ -f  /etc/schroot/chroot.d/buildroot ] && chown -R $USERNAME:$USERNAME /var/chroot/buildroot  && sed -ri "s/(users=.*)/\1,$USERNAME/g" /etc/schroot/chroot.d/buildroot || true
+    && chmod 0440 /etc/sudoers.d/$USERNAME
+RUN chown -R $USERNAME:$USERNAME /opt/debs
+RUN [ -f  /etc/schroot/chroot.d/buildroot ] && sed -ri "s/(users=.*)/\1,$USERNAME/g" /etc/schroot/chroot.d/buildroot || true
 
 # ********************************************************
 # * Anything else you want to do like clean up goes here *

diff --git a/armhf-container/devcontainer.json b/armhf-container/devcontainer.json
@@ -30,7 +30,7 @@
 	,
 	"containerEnv": {
 		"CMAKE_TOOLCHAIN_FILE": "/usr/share/cmake/toolchain.cmake",
-		"CMAKE_GENERATOR": "Ninja"
+		"CMAKE_GENERATOR": "Unix Makefiles"
 	},
 	"customizations": {
 		"vscode": {