Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storyboard example in markdown #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dobiedad
Copy link

@dobiedad dobiedad commented Apr 1, 2015

No description provided.

@Ekhoo
Copy link
Owner

Ekhoo commented Apr 1, 2015

What is the difference ? Do you forget to call the play method ? And please, remove the .DS_STORE.

Thank you for your pull request, but I can't merge it yet.

@dobiedad
Copy link
Author

dobiedad commented Apr 1, 2015

Your example does not work with storyboard.

The difference is in the storyboard example
_videoSpeed = 1.0f; is called,

This is needed because
[self play]; does nothing, if (self) { _repeat = YES; _videoSpeed = 1.0f; _maskTintColor = [UIColor clearColor]; _maskAlpha = 0.0f; } in EKVideoController.m never gets called and _videoSpeed stays 0

@ghost
Copy link

ghost commented Jun 29, 2015

This pull request is needed! Very important. Your example does not work with storyboard, unless _videoSpeed = 1.0f; is called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants