Changes to add IMU to andino firmware #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzodepedro
requested review from
francocipollone and
jballoffet
as code owners
jballoffet
requested changes
Feb 7, 2024
There was a problem hiding this comment.
Thanks @gonzodepedro, @ivanpauno and @fbaglivo for contributing to Andino! I have reviewed the code changes and left some comments, PTAL. Thanks!
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Javier Balloffet <[email protected]>
jballoffet
approved these changes
May 12, 2024
There was a problem hiding this comment.
Comments addressed. Thanks @gonzodepedro, @ivanpauno and @fbaglivo for contributing to Andino!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Relates to #50
Summary
Adds imu functionality to firmware.
Relates to #181
In "Arduino IDE" they have to be added manually (added details in README).
For new bootloader, it should work with the
unoenvironment and if not we should later addnanoatmega328new.Test it
BNO055 is needed.
I used plotjuggler to plot orientation z (yaw), and veriefied it's working fine.
Ask @fbaglivo , @ivanpauno or me for details.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.