Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongoid 9 support #21

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Mongoid 9 support #21

wants to merge 4 commits into from

Conversation

danarnold
Copy link

Mongoid seems to have moved the functionality from Mongoid::Association::Referenced::Eager::Base into Mongoid::Association::Eager. Changing the prepend to work on that module seems to make everything work as expected.

Additionally, I updated the Gemfile.lock to get the tests running. I am getting one test failure, on Mongoid::Includes::Criteria#includes multiple inclusions through polymorphic associations :with inclusions should not be overriden (expected: 4 times with any arguments, received: 3 times with any arguments). However, this also fails without any changes related to mongoid 9, so I don't think it's related to any changes I made. I also needed to add a Time.zone specification to the spec_helper, which is now required by mongoid.

@1st8
Copy link

1st8 commented Aug 30, 2024

The test failure is also present with Mongoid 7 and 8.1. Just to confirm that it's not related to your changes.

@danarnold danarnold mentioned this pull request Aug 30, 2024
@jclusso
Copy link

jclusso commented Oct 2, 2024

@ElMassimo any plans to review / merge this?

@cperezabo
Copy link

I don't understand the silence, he is not dead because he has pushed to another repo few hours ago.
Test are passing, it just needs a click to merge and publish the gem update (if not automatically done)
🤷🏻‍♂️

@jclusso
Copy link

jclusso commented Oct 15, 2024

I don't understand the silence, he is not dead because he has pushed to another repo few hours ago. Test are passing, it just needs a click to merge and publish the gem update (if not automatically done) 🤷🏻‍♂️

@cperezabo only guess I have is he has notifications turned off for this repo or something.

@danarnold danarnold mentioned this pull request Oct 15, 2024
@remz99
Copy link

remz99 commented Jan 12, 2025

@ElMassimo any plans merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants