Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1332] Enable Swiftlint workflow #1333

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[#1332] Enable Swiftlint workflow #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/swiftlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: SwiftLint

on:
pull_request:
paths:
- '.github/workflows/swiftlint.yml'
- '.swiftlint.yml'
- '**/*.swift'

jobs:
SwiftLint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: GitHub Action for SwiftLint
uses: norio-nomura/[email protected]

2 changes: 1 addition & 1 deletion Sources/ZcashLightClientKit/Checkpoint/BundleCheckpointSource.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ struct BundleCheckpointSource: CheckpointSource {

func birthday(for height: BlockHeight) -> Checkpoint {
Checkpoint.birthday(
with: height,
with: height,
checkpointDirectory: BundleCheckpointURLProvider.default.url(self.network)
) ?? saplingActivation
}
Expand Down
4 changes: 0 additions & 4 deletions Sources/ZcashLightClientKit/Modules/Service/LightWalletService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
}

extension LightWalletServiceError: Equatable {
// swiftlint:disable cyclomatic_complexity

Check warning on line 27 in Sources/ZcashLightClientKit/Modules/Service/LightWalletService.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

Blanket Disable Command Violation: The disabled 'cyclomatic_complexity' rule should be re-enabled before the end of the file (blanket_disable_command)
public static func == (lhs: Self, rhs: Self) -> Bool {
switch lhs {
case .generalError(let message):
Expand Down Expand Up @@ -137,10 +137,6 @@
struct LightWalletServiceFactory {
let endpoint: LightWalletEndpoint

init(endpoint: LightWalletEndpoint) {
self.endpoint = endpoint
}

func make() -> LightWalletService {
return LightWalletGRPCService(endpoint: endpoint)
}
Expand Down
4 changes: 0 additions & 4 deletions Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackend.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ import libzcashlc
struct ZcashKeyDerivationBackend: ZcashKeyDerivationBackendWelding {
let networkType: NetworkType

init(networkType: NetworkType) {
self.networkType = networkType
}

// MARK: Address metadata and validation
static func getAddressMetadata(_ address: String) -> AddressMetadata? {
var networkId: UInt32 = 0
Expand Down
Loading