[#1514] finish multi account support #1522

LukasKorba · 2025-01-10T08:36:26Z

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
Automated tests: Did you add appropriate automated tests for any code changes?
Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
Run the app: Did you run the app and try the changes?
Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

Checklist review: Did you go through the code with the Code Review Guidelines checklist?
Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
Automated tests: Did you review the automated tests?
Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

…nt structure - First iteration of all Int account references to an instance of an Account

- swift-grps dependency bumped to 1.24.2

- The ID of account is now public co clients can read-only it

- Zip32 accounts represented with Int32 are now refactored to Zip32Account - from_account_id/fto_account_id are now refactored to AccountId

- Zip32Account(Int32) has been refactored to Zip32AccountIndex(UIn32)

- WalletSummary's accountBalances dictionary has been refactored to use Zip32AccountIndex instead of UInt32 for the keys

- Some comments updated to reflect reality - Some Tests fixed

…entation-from-Int-to-a-dedicated-Account-structure [#1511] Refactor account representation from int to a dedicated account structure

- The SDK no longer assumes a default account. All business logic with instances of Zip32AccountIndex(<index>) has been refactored.

- Updated the code to not call getWalletSummary() with each loop iteration

…s-not-assume-a-default-account-anywhere [#1512] Ensure that the SDK does not assume a default account anywhere

- the FFI has been switched to a preview of import UFVK

- importAccount() WIP

- Some of the Zip32AccountIndex has been refactored to UUID - Public import UFVK method in the SDK added AccountUUID refactor - phase 1 - rebased

- SDK builds again, UUIDs refactored everywhere in the SDK and demo app - tests will follow in the next phase - refactor of documented code in the follow up

- Comments in the code updated and cleaned up - OfflineTests passes again, those failing has been removed from the bundle and marked to be fixed with a TODO Fixes of build - The SDK builds again

CI xcode bump

OfflineTests fixes

- updated to build and tests that are obsolete are now taken out of the bundle

- rust backend `getAccount` method implemented, it returns Account with associated data - `listAccount()` has been modified to return an array of Accounts instead of AccountUUIDs

- Account refactored to conform to Equatable, Hashable, Codable, Identifiable

- importAccount(ufvk, purpose, name, keySource) API

UnifiedAddress Hashable conformance

- a new public API for DerivationTool to derive UA from the UFVK added

- also attempt to fix _uuid in views

- Refactored to the proper types

- ufvk removed from the parameters

from_account_uuid

alias reverted Alias logic updated

- The comments were provided - Changelog updated - Code cleaned up - Tests fixed - Error codes for the Pczt

- FFI version bumped to 0.12.0

Multi-account and PCZT support

LukasKorba and others added 30 commits November 19, 2024 11:11

[#1511] Refactor account representation from Int to a dedicated Accou…

a0535a6

…nt structure - First iteration of all Int account references to an instance of an Account

GRPC bump

4462a8f

- swift-grps dependency bumped to 1.24.2

Account id public

d00c970

- The ID of account is now public co clients can read-only it

Zip32Account and AccountId

b31e1c9

- Zip32 accounts represented with Int32 are now refactored to Zip32Account - from_account_id/fto_account_id are now refactored to AccountId

Zip32AccountIndex UInt32 refactor

9713751

- Zip32Account(Int32) has been refactored to Zip32AccountIndex(UIn32)

Account balances refactor UInt32 to Zip32AccountIndex

ea549c3

- WalletSummary's accountBalances dictionary has been refactored to use Zip32AccountIndex instead of UInt32 for the keys

PR Comments addressed

6505d5f

- Some comments updated to reflect reality - Some Tests fixed

Merge pull request #1515 from LukasKorba/1511-Refactor-account-repres…

670f2ce

…entation-from-Int-to-a-dedicated-Account-structure [#1511] Refactor account representation from int to a dedicated account structure

[#1512] Ensure that the SDK does not assume a default account anywhere

35ddf87

- The SDK no longer assumes a default account. All business logic with instances of Zip32AccountIndex(<index>) has been refactored.

getWalletSummary out of the loop

db3a4b9

- Updated the code to not call getWalletSummary() with each loop iteration

Merge pull request #1516 from LukasKorba/1512-Ensure-that-the-SDK-doe…

a48a75d

…s-not-assume-a-default-account-anywhere [#1512] Ensure that the SDK does not assume a default account anywhere

import-ufvk-ffi

a09f2b1

- the FFI has been switched to a preview of import UFVK

ImportAccount UFVK

3bfe5b3

- importAccount() WIP

AccountUUID refactor - phase 1

06181fb

- Some of the Zip32AccountIndex has been refactored to UUID - Public import UFVK method in the SDK added AccountUUID refactor - phase 1 - rebased

AccountUUID refactor - phase 2

7a6bd72

- SDK builds again, UUIDs refactored everywhere in the SDK and demo app - tests will follow in the next phase - refactor of documented code in the follow up

PR Comments addressed and code cleaned up

27af6f1

- Comments in the code updated and cleaned up - OfflineTests passes again, those failing has been removed from the bundle and marked to be fixed with a TODO Fixes of build - The SDK builds again

Update swift.yml

2b3ff26

CI xcode bump

Update swift.yml

92bd2e6

Generated mocks

05002a8

OfflineTests fixes

Performance, Network and Dark side tests

bb03333

- updated to build and tests that are obsolete are now taken out of the bundle

getAccount for UUID

5179f4e

- rust backend `getAccount` method implemented, it returns Account with associated data - `listAccount()` has been modified to return an array of Accounts instead of AccountUUIDs

Account conformace

e48cd60

- Account refactored to conform to Equatable, Hashable, Codable, Identifiable

hd_account_index wrapped in Zip32AccountIndex

df1b319

account_id -> account_uuid refactor

89773c6

Public importAccount method

f69aa19

- importAccount(ufvk, purpose, name, keySource) API

seedFingerprint and zip32AccountIndex parameters in importAccount added

8c099e3

Codable UnifiedAddress conformance

dcf6cd9

UnifiedAddress Hashable conformance

Optional account_name

7782d6f

FFI bump

32bb9ba

DerivationTool.deriveUnifiedAddressFrom(ufvk)

08e5a73

- a new public API for DerivationTool to derive UA from the UFVK added

LukasKorba and others added 16 commits December 10, 2024 14:39

PCZT methods

6bab337

- also attempt to fix _uuid in views

PCZT methods updated

0fba7f2

- Refactored to the proper types

FFI bump

5943d63

PCZT API updated

30af9c6

- ufvk removed from the parameters

from_account_id reverted

dd587ac

from_account_uuid

FFI bumped

26ad508

Reset of synchronizer alias

632626a

alias reverted Alias logic updated

FFI bump

ee32938

Create and submit PCZT

f499898

Alias checker disconnected

fb38ac8

Pczt typealias and clean up

da00a69

- The comments were provided - Changelog updated - Code cleaned up - Tests fixed - Error codes for the Pczt

Code cleanup

f16d098

FFI 0.12.0 bump

ce667eb

- FFI version bumped to 0.12.0

Review comments addressed

a8b1524

Comments updated

3bea79c

Merge pull request #1517 from LukasKorba/import-ufvk-ffi-preview

f7029ed

Multi-account and PCZT support

LukasKorba requested review from Milan-Cerovsky and HonzaR January 10, 2025 08:37

HonzaR approved these changes Jan 10, 2025

View reviewed changes

LukasKorba merged commit 4233e26 into main Jan 10, 2025
1 of 2 checks passed

LukasKorba deleted the 1514-Finish-multi-account-support branch January 10, 2025 09:02

LukasKorba restored the 1514-Finish-multi-account-support branch January 10, 2025 10:03

nuttycom deleted the 1514-Finish-multi-account-support branch January 23, 2025 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#1514] finish multi account support #1522

[#1514] finish multi account support #1522

LukasKorba commented Jan 10, 2025

[#1514] finish multi account support #1522

[#1514] finish multi account support #1522

Conversation

LukasKorba commented Jan 10, 2025

Author

Reviewer