Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature addresses some minor permission issues with the current Cirrus Lambda code and adds the ability to use custom Cirrus Lambda Dist ZIPs.
Related issue(s)
Proposed Changes
cirrus_lambda_dist_zip_filepath
was added to allow a custom ZIP to be used for all cirrus lambdas (API, process, update-state, pre-batch, and post-batch). This change enables compatibility testing and/or version pinning of a specific cirrus build rather than always using the default version included with this repository. If a custom ZIP is not provided, the default is used.v1.0.0a0
update-state
lambda is grantedsns:Publish
permissions for both thepublish
topic and theworkflow_event
topic.update-state
lambda is granteds3:PutObject
in addition to the existings3:GetObject
permissions on the Cirrus payload bucket (necessary for uploading a process payload to S3 if it is not already there).events:PutEvents
permissions in order to push state transition events.cirrus_update_state
CloudWatch event rule had an invalid prefix ARN that prevented events from workflow state machines being captured.Testing
This change was validated by the following observations:
cirrus_inputs.lambda_dist_zip_filepath
. Deploying this change resulted in each cirrus lambda being updated accordingly.update-state
lambda.update-state
lambda executed successfully, resulting in a push to the cirruspublish
SNS topic.Checklist