Ability to unblacklist runes #8037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migration was introduced in dccbccf (pre 23.08), so the only way they would need this is if they migration straight from 23.05 to 25.02. And then the solution is to migration to a prior one first, but I'll bet good money we never, ever see this message: Commando runes still present? Migration removed in v25.02: call Rusty! Signed-off-by: Rusty Russell <[email protected]>
Sure, we have to convert to and from the db set-of-pairs, but that's far simpler than dealing with the current structure now we want to add code to *remove* from the blacklist. Changelog-Changed: JSON-RPC: `blacklistrune` no longer supports of runes over id 100,000,000. Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: JSON-RPC: `blacklistrune` now has an option to un-blacklist (`relist`).
rustyrussell
force-pushed
the
guilt/unblacklist-runes
branch
from
1cf9588 to
d50aa0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7017