elementsd-tests: blind asset issuance based on node version #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Elements 22 there was a change in the `createpsbt` RPC that causes our integration tests to fail. This is fixed by disabling blinding. Patch by Leo Comandini, adapted by me to still work with 0.21, from ElementsProject#214
|
Will test on my local CI box with a few different Elements versions. |
|
Not working with 23.2.4. Investigating. |
|
Hmm, must've just been intermittent. |
|
cc @RCasatta @LeoComandini I think this is good to go. Can one of you ACK it? |
delta1
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Elements 22 there was a change in the
createpsbtRPC that causes our integration tests to fail. This is fixed by disabling blinding.Patch by Leo Comandini, adapted by me to still work with 0.21, from #214
Fixes #214