v11 RollTables fix #162
Open
v11 RollTables fix #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current GmScreen almost works as-is on v11. The only issue I found was with RollTables, which don't render properly. This is caused by three things:
getDatais now async, so it always returns a promiseTextEditor.enrichHTMLis now async by default, but you can pass it a flag to make it syncCONST.TABLE_RESULT_TYPESno longer has theENTITYtype, but instead aDOCUMENTtypeThis PR fixes these issues and allows RollTables to be rendered correctly on the GmScreen. Also, the
activateListenersof the RollTable must be overriden, as it tries to set attributes of elements that do not exist. It does not stop rendering, but floods the console with error logs.Let me know if you're fine with having a direct bump to v11 that doesn't work in v10, or if you'd rather have a check that changes the behavior depending on the detected version