Feature/sentry stale event check #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesndrs
force-pushed
the
feature/sentry_stale_event_check
branch
from
6be1846 to
f851b8b
Compare
fbacall
reviewed
Oct 21, 2024
| @@ -79,6 +79,8 @@ def run | |||
| end | |||
| end | |||
|
|
|||
| scraper_event_check(data_sources) | |||
There was a problem hiding this comment.
Maybe just call this from within the scrape method? Then you don't have to iterate over all the data sources again.
There was a problem hiding this comment.
I opted for afterwards since you can have multiple sources with the same content_provider so if you check right after the source specific scrape you are checking on events that have not been rescraped yet. Should not be a problem if the difference between your stale threshold and your scraping frequency is big enough but this felt cleaner.
fbacall
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added config option to check for disproportionate amount of stale or rejected events after scraping. Send sentry warning if threshold is met.
Checklist
to license it to the TeSS codebase under the
BSD license.