Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material curation mail #1049

Merged

Conversation

mikesndrs
Copy link
Contributor

@mikesndrs mikesndrs commented Nov 19, 2024

Summary of changes
Add curation mailer for materials
Wait for material hide option PR (#1050)

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

Copy link
Member

@fbacall fbacall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the field name

Can you rebase this on master now that the visible PR was merged?

Also I noticed you are not yet listed on https://github.com/ElixirTeSS/TeSS/blob/master/CONTRIBUTORS.md so feel free to add yourself

app/mailers/curation_mailer.rb Outdated Show resolved Hide resolved
@mikesndrs mikesndrs force-pushed the feature/material_curation_mailer branch from aa64797 to 9b7afbf Compare December 2, 2024 09:38
@mikesndrs mikesndrs requested a review from fbacall December 2, 2024 10:54
@fbacall fbacall merged commit 2228239 into ElixirTeSS:master Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants