Remove source URL validation in scraper #1056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
validate_url
call when running a source through aScraper
.with_net_connection
test method to allow real network calls in tests if needed (currently used to testprivate_address_check
is working).Motivation and context
A user created a source with a URL that returned a 301 redirect. This worked fine when testing, but was considered invalid when running through the scraper. The URL format is already validated when creating a source, and any issues when resolving the URL should be raised when running the actual
Ingestor
.Checklist
to license it to the TeSS codebase under the
BSD license.