Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activities refactor #1073

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Activities refactor #1073

merged 7 commits into from
Jan 6, 2025

Conversation

fbacall
Copy link
Member

@fbacall fbacall commented Jan 2, 2025

Summary of changes

  • Use shared partials for rendering activities to DRY up the code.
  • Make sure activities can still render even if associated resources have since been deleted.
  • Use i18n for activity text.
  • Test each activity renders without error.

Motivation and context

Previously, each resource type had its own set of activity partials for each activity type, even though they were almost always identical to other types' partials. When a new resource type was added, often these partials were missing and would cause errors when trying to render the activity log (which was not picked up by any tests).

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

@fbacall fbacall merged commit 1cd7517 into master Jan 6, 2025
11 checks passed
@fbacall fbacall deleted the activities-refactor branch January 6, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant