sdm845-common: SELinux init and sync some configs from Xiaomi tree #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oobaboo
force-pushed
the
selinux
branch
2 times, most recently
from
072f277 to
013b2aa
Compare
sajattack
reviewed
Oct 2, 2023
sepolicy/vendor/temp.te
Outdated
| add_hwservice(rild, default_android_hwservice) | ||
| binder_call(rild, init) | ||
| set_prop(rild, vendor_default_prop) | ||
| binder_call(rild, hal_lgdata_default) |
sajattack
reviewed
Oct 3, 2023
sepolicy/vendor/temp.te
Outdated
| add_hwservice(init, hal_nxpnfc_hwservice) | ||
| add_hwservice(init, hal_power_stats_hwservice) | ||
| add_hwservice(init, hal_thermal_hwservice) | ||
| add_hwservice(init, hal_vibrator_hwservice) |
There was a problem hiding this comment.
something in this pr broke the vibration motor.
hwservicemanager: Tried to start [email protected]::IVibrator/default as a lazy service, but was unable to. Usually this happens when a service is not installed, but if the service is intended to be used as a lazy service, then it may be configured incorrectly.
I tried manually adding vendor.qti.hardware.vibrator.service to PRODUCT_PACKAGES and that suppressed the error but the hardware still won't function.
Other than the handful of issues I mentioned, great work! Do you have any plans to remove |
|
Sorry it seems I missed the existence of this repo https://github.com/oobaboo/android_device_lge_common |
sajattack
approved these changes
Oct 3, 2023
It's pointless when using extern "C". Change-Id: Ibdf9f06a70aa3a75687b33781c78cf2172bb334d
Return a positive integer for perf lock acquire and release so that Goodix/FPC fingerprint sensor blobs will not complain. Goodix: E [goodixHAL][gf_hal_milan_f_series]: goodix_perf_lock_acquire: Failed to acquire perf lock, err: 0 E [goodixHAL][gf_hal_milan_f_series]: goodix_perf_lock_release: Perf lock release error 0 FPC: E fpc_tac : fpc_perf_lock_acquire: Incorrect params, Failed to acquire perf lock, err E fpc_tac : fpc_perf_lock_release: Perf lock release error 0 Signed-off-by: Chenyang Zhong <[email protected]> Change-Id: I861672e9a738c2204755d802670f4b28b662f286
* Why bothering with C++ mangling when we can just build it as a standard C library? Change-Id: I45ea977edf7ea7fab6fece76f3049654a8d24c5d
EmanuelCN
force-pushed
the
T
branch
2 times, most recently
from
3563407 to
20f91f0
Compare
EmanuelCN
force-pushed
the
T
branch
2 times, most recently
from
fab04f3 to
91119f2
Compare
EmanuelCN
force-pushed
the
T
branch
8 times, most recently
from
1bfc915 to
8d0aa02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.