Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(wallet-mobile): Add scroll to modals #3793

Merged
merged 3 commits into from
Jan 22, 2025
Merged

refactor(wallet-mobile): Add scroll to modals #3793

merged 3 commits into from
Jan 22, 2025

Conversation

jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo commented Jan 21, 2025 •
edited
Loading

Description / Change(s) / Related issue(s)

Ticket

https://emurgo.atlassian.net/browse/YV-83

  • Modify openModal from ordered arguments to named arguments
  • Modify ModalContext to add footer
  • Modify ModalScreen to have scroll and use footer (optional)
  • Refactor every usage of openModal to new named arguments
  • Refactor every modal to remove scroll
  • Refactor every most modal to have the buttons in the new footer

@jorbuedo jorbuedo added wip Shows that a PR shouldn't be merge refactor labels Jan 21, 2025
@jorbuedo jorbuedo self-assigned this Jan 21, 2025
@jorbuedo jorbuedo marked this pull request as ready for review January 22, 2025 14:03
@jorbuedo jorbuedo removed the wip Shows that a PR shouldn't be merge label Jan 22, 2025
@stackchain stackchain merged commit ce86c66 into develop Jan 22, 2025
1 check passed
@stackchain stackchain deleted the YV-83 branch January 22, 2025 15:31
@stackchain stackchain added this to the 5.3.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackchain stackchain stackchain approved these changes

@michaeljscript michaeljscript michaeljscript approved these changes

Assignees

@jorbuedo jorbuedo

Labels
refactor
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jorbuedo @michaeljscript @stackchain